On Mar 8, 2008, at 12:10 PM, Wayne Davison wrote:
> The attached patch turns on more extensive warnings in gcc (-W) and
> fixes a bunch of unused-arg warnings and one signed/unsigned
> warning. Non-gcc compilers should be unaffected.
> This should help to find problems in the future, and will allow other
> packages (such as rsync) to compile the popt code with -W w/o compiler
> warnings showing up.
I'm not really sure that adding __attribute__((__unused__)) helps
anything. All of the changes were already marked with splint
/*@unused@*/ which are regularly verified with "make lint".
OTOH the patch hurts nothing but compiler portability complexity.
Added, thanks for the patch.
73 de Jeff
Received on Sat Mar 8 18:30:39 2008