RPM Community Forums

Mailing List Message of <popt-devel>

Re: popt-1.16: patch for building on NetBSD-current

From: Jeff Johnson <n3npq@mac.com>
Date: Sat 05 Jun 2010 - 17:15:17 CEST
Message-id: <7961F5E5-D4D0-40EA-9215-9F0EDA854479@mac.com>

On Jun 5, 2010, at 9:29 AM, Thomas Klausner wrote:

> Hi!
> 
> Since NetBSD-5.99.11, glob_pattern_p is included in libc.
> 
> The attached patch fixes the resulting compilation problem. Please
> include it in the next release.
> 

I'd rather see a HAVE_GLOB_PATTERN_P test in AutoFu, with
all the bleary platform tests isolated in "system.h", than
having a Sysiphean litter of
	+#if defined(__NetBSD__)
	+#include <sys/param.h>
	+#endif 
platform tests everywhere in the code.

No worries, I'll adjust your patch to my fetishism ...

Thanks for the report. Holler at me if the issue slips, I won't
be working on POPT 2.0 quite yet, a few more weeks to clear some space.

73 de Jeff
Received on Sat Jun 5 17:15:58 2010
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.