RPM Community Forums

Mailing List Message of <rpm-cvs>

[CVS] RPM: popt/ poptparse.c

From: Jeff Johnson <jbj@rpm5.org>
Date: Fri 13 Jul 2007 - 14:24:01 CEST
Message-Id: <20070713122401.278573484F1@rpm5.org>
  RPM Package Manager, CVS Repository
  http://rpm5.org/cvs/
  ____________________________________________________________________________

  Server: rpm5.org                         Name:   Jeff Johnson
  Root:   /v/rpm/cvs                       Email:  jbj@rpm5.org
  Module: popt                             Date:   13-Jul-2007 14:24:01
  Branch: HEAD                             Handle: 2007071313240000

  Modified files:
    popt                    poptparse.c

  Log:
    plug another memory leak on an error retrun path.

  Summary:
    Revision    Changes     Path
    1.25        +4  -1      popt/poptparse.c
  ____________________________________________________________________________

  patch -p0 <<'@@ .'
  Index: popt/poptparse.c
  ============================================================================
  $ cvs diff -u -r1.24 -r1.25 poptparse.c
  --- popt/poptparse.c	12 Jul 2007 17:22:44 -0000	1.24
  +++ popt/poptparse.c	13 Jul 2007 12:24:00 -0000	1.25
  @@ -67,7 +67,10 @@
   
       if (argv == NULL) return rc;
       buf = bufOrig = calloc(1, buflen);
  -    if (buf == NULL) return rc;
  +    if (buf == NULL) {
  +	free(argv);
  +	return rc;
  +    }
       argv[argc] = buf;
   
       for (src = s; *src != '\0'; src++) {
  @@ .
Received on Fri Jul 13 14:24:01 2007
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.