RPM Package Manager, CVS Repository
  http://rpm5.org/cvs/
  ____________________________________________________________________________

  Server: rpm5.org                         Name:   Jeff Johnson
  Root:   /v/rpm/cvs                       Email:  jbj@rpm5.org
  Module: rpm                              Date:   06-Dec-2007 23:06:33
  Branch: HEAD                             Handle: 2007120622063201

  Modified files:
    rpm                     CHANGES TODO
    rpm/build               pack.c

  Log:
    - jbj: fix: rpmbuild --sign needed to test for password entry.

  Summary:
    Revision    Changes     Path
    1.1954      +1  -0      rpm/CHANGES
    1.44        +2  -1      rpm/TODO
    2.270       +1  -1      rpm/build/pack.c
  ____________________________________________________________________________

  patch -p0 <<'@@ .'
  Index: rpm/CHANGES
  ============================================================================
  $ cvs diff -u -r1.1953 -r1.1954 CHANGES
  --- rpm/CHANGES	6 Dec 2007 21:46:52 -0000	1.1953
  +++ rpm/CHANGES	6 Dec 2007 22:06:32 -0000	1.1954
  @@ -1,4 +1,5 @@
   5.0a4 -> 5.0b1:
  +    - jbj: fix: rpmbuild --sign needed to test for password entry.
       - jbj: display the rpmlib Version/Timestamp/Vendor markers lest I forget.
       - jbj: macro expand all scriptlet bodies before execution. W00t!
       - jbj: populate RPMTAG_BUILDMACROS. implementation took 6+ years ...
  @@ .
  patch -p0 <<'@@ .'
  Index: rpm/TODO
  ============================================================================
  $ cvs diff -u -r1.43 -r1.44 TODO
  --- rpm/TODO	6 Dec 2007 21:32:15 -0000	1.43
  +++ rpm/TODO	6 Dec 2007 22:06:32 -0000	1.44
  @@ -55,7 +55,6 @@
       - jbj: markReplacedFiles() subtly rewrites header back into rpmdb
   	with altered RPMTAG_FILESTATES data. get/del/add sequence
   	is needed instead.
  -    - jbj: check that rpmbuild --sign is functional, or eliminate the option.
       - jbj: choose between db-4.5.20 and db-4.6.21. db-4.5.20 may have fewer
   	upgrade/downgrade issues because of the db-4.6.21 DB_HASH change,
   	but rpm-5.0 already uses DB_BTREE for Packages.
  @@ -105,6 +104,8 @@
       - jbj: fix openssl RSA signature verification.
       - jbj: drill Requires: sanitycheck(N) = E:V-R runtime probe.
       - jbj: write up added featlets/bugtures in %docdir notes.
  +    - jbj: rpmbuild --sign is functional. However, behavior may have changed
  +	for empty passwords when not using linux keyutils. Should I care?
   
     RPM 5.1 ROADMAP ISSUES
     ----------------------
  @@ .
  patch -p0 <<'@@ .'
  Index: rpm/build/pack.c
  ============================================================================
  $ cvs diff -u -r2.269 -r2.270 pack.c
  --- rpm/build/pack.c	6 Dec 2007 20:49:16 -0000	2.269
  +++ rpm/build/pack.c	6 Dec 2007 22:06:33 -0000	2.270
  @@ -765,7 +765,7 @@
       (void) rpmAddSignature(sigh, sigtarget, RPMSIGTAG_MD5, passPhrase);
   
       sigtag = RPMSIGTAG_GPG;
  -    addsig = 0;	/* XXX breaks --sign */
  +    addsig = (passPhrase && passPhrase[0]);
   
       if (addsig) {
   	rpmlog(RPMLOG_NOTICE, _("Generating signature: %d\n"), sigtag);
  @@ .