On May 28, 2007, at 5:12 AM, Olivier Thauvin wrote:

> Hi,
>
> I am currently able to build rpm from CVS only when using:
>
> "./configure --prefix /usr"
>
> The issue come from beecrypt include dir, configure.ac search  
> "beecrypt/any.h"
> but later hardcode "-I/beecrypt" and so in this
> is "/usr/local/include" whereas beecrypt is installed into "/usr/ 
> include/".
>
> Also in rpmio_internal.h we have such code:
> #include "beecrypt.h"
>
> but it should be "beecrypt/beecrypt.h" except when using internal one.
>
> Suggest fix:
>
> - removing "-I/beecrypt" if found
> - adding a define in config.h "#RPM_INTERNAL_BEECRYPT"
> - changing {.h,.c} to something like
>
> #ifdef #RPM_INTERNAL_BEECRYPT
> #include "beecrypt.h"
> #else
> #include "beecrypt/beecrypt.h"
> #endif
>
> Do you agree with that ?
>

In general, I believe that adjusting -I paths is superior to embedding
partial relative structure within include paths as in
     #include "beecrypt/beecrypt.h"

There are valid arguments for partial relative paths as well, I'm  
just trying
to warn you of my habits within rpm code.

But in this case I'm much more interested that you feel confident
in checking in code that works for you.

So Go fer it!

The issue can be easily sorted out when rpm5.org gets sufficiently  
far along
to actually attempt to prepare a candidate release.

73 de Jeff