RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: zlib/ Makefile.am

From: Jeff Johnson <n3npq@mac.com>
Date: Tue 04 Sep 2007 - 18:58:10 CEST
Message-Id: <CF19CF45-4DE2-4CAD-9BCE-F569264CDB67@mac.com>
If this is what "fixes" make -jX, then there is a missing dependency
from minigzip -> libz.a somewhere. Note that eliminating example
and minigzip eliminates, rather than fixes, the make -jX problem.

minigzip may be needed somewhen for precisely (i.e. absolutely
identical) *.rpm, the padding in internal zlib is different because
of --rsyncable.

73 de Jeff

On Sep 4, 2007, at 12:51 PM, Robert Scheck wrote:

>  RPM Package Manager, CVS Repository
>  http://rpm5.org/cvs/
>   
> ____________________________________________________________________________
>
>  Server: rpm5.org                         Name:   Robert Scheck
>  Root:   /v/rpm/cvs                       Email:  robert@rpm5.org
>  Module: zlib                             Date:   04-Sep-2007 18:51:22
>  Branch: HEAD                             Handle: 2007090417512200
>
>  Modified files:
>    zlib                    Makefile.am
>
>  Log:
>    Unbreak zlib when building rpm by using 'make -jX' here, too
>
>  Summary:
>    Revision    Changes     Path
>    1.25        +2  -1      zlib/Makefile.am
>   
> ____________________________________________________________________________
>
>  patch -p0 <<'@@ .'
>  Index: zlib/Makefile.am
>   
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
>  $ cvs diff -u -r1.24 -r1.25 Makefile.am
>  --- zlib/Makefile.am	18 Aug 2007 11:51:36 -0000	1.24
>  +++ zlib/Makefile.am	4 Sep 2007 16:51:22 -0000	1.25
>  @@ -17,7 +17,8 @@
>   	trees.c uncompr.c zutil.c
>   librpmz_la_LDFLAGS =
>
>  -noinst_PROGRAMS = example minigzip
>  +# Don't uncomment the following line or make -jX will break
>  +# noinst_PROGRAMS = example minigzip
>
>   example_SOURCES = example.c
>   example_LDFLAGS = librpmz.la
>  @@ .
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> CVS Sources Repository                                rpm-cvs@rpm5.org
Received on Tue Sep 4 18:58:13 2007
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.