RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm-4_5: rpm/ CHANGES zlib/ configure.ac

From: Ralf S. Engelschall <rse+rpm-devel@rpm5.org>
Date: Sat 08 Sep 2007 - 08:59:47 CEST
Message-ID: <20070908065947.GA44161@engelschall.com>
On Sat, Sep 08, 2007, Jeff Johnson wrote:

>     - mej: remove -pie flags passed from rpm.spec when configuring zlib
>     build.
> [...]
>   $ cvs diff -u -r1.7.2.1 -r1.7.2.2 configure.ac
>   --- zlib/configure.ac	18 Aug 2007 12:53:59 -0000	1.7.2.1
>   +++ zlib/configure.ac	8 Sep 2007 00:00:43 -0000	1.7.2.2
>   @@ -5,6 +5,8 @@
>    AM_CONFIG_HEADER([config.h])
>    AM_INIT_AUTOMAKE([-Wall foreign])
>
>   +LDFLAGS=""
>   +
>    dnl Check for programs.
>    AC_PROG_CC
>    AC_PROG_LIBTOOL
>   @@ .

Here we have to be careful. This destroys actually _ALL_ LDFLAGS, even
those the user manually passed in. If it contains some essential flags
(e.g. some platform specific and essential "-Wl,xxxx") this _COULD_
break the building. Also, -pie is platform-specific but this hack
applies to all platforms. Hmmm.... hence we certainly have to make this
hack less generic....

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com
Received on Sat Sep 8 09:01:15 2007
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.