On Oct 1, 2007, at 11:35 AM, Jason Corley wrote:

> Not sure if this is due to latest refactoring or something else.  Just
> tried to do my devtool build this morning and it crapped.  Paste
> below.
> Jason
>
> -----
>
> Making install in perl
> make -f Makefile.perl || make -f Makefile.perl
> cc -c  -I../. -I../build -I../lib -I../popt -I../rpmdb -I../rpmio
> -I../rpmconstant  -DRPM_OS_DARWIN=081001 -I/usr/local/src/bzip2-1.0.4
> -I/usr/local/src/beecrypt-4.1.2 -I/usr/local/src/neon-0.27.2/src
> -I/usr/local/src/popt-1.12 -I/usr/local/src/sqlite-3.5.0 -Wall
> -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes
> -Wno-char-subscripts -O0 -g3 -D_GNU_SOURCE -D_REENTRANT -g
> -DVERSION=\"5.0.DEVEL\" -DXS_VERSION=\"5.0.DEVEL\"
> "-I/System/Library/Perl/5.8.6/darwin-thread-multi-2level/CORE"
> RPM_Transaction.c
> RPM_Transaction.xs:135: warning: no previous prototype for  
> 'transCallback'
> RPM_Transaction.c: In function 'XS_RPM__Transaction_new':
> RPM_Transaction.c:246: warning: unused variable 'class'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_vsflags':
> RPM_Transaction.xs:262: warning: implicit declaration of function  
> 'sv2constant'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_packageiterator':
> RPM_Transaction.xs:297: warning: implicit declaration of function  
> '_newiterator'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_dbadd':
> RPM_Transaction.xs:308: error: too many arguments to function  
> 'rpmdbAdd'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_dbremove':

An argument was removed in 3 functions. I can back  an unused argument
if necessary. Lemme look this evening. The quick hack is to delete the  
last argument.

I do question whether rpmdbAdd/rpmdbRemove/rpmdbRebuilddb/rpmdbVerify  
(and
rpmdbOpen/rpmdbClose) are the right bindings in the first place. An  
alternative binding through
rpmcli functions using strings is easier maintenance. If I add back  
the unused argument, it
will take years to remove. Passing the transaction set deep into  
librpmdb and librpmio
in order to preserve forward linkage without reference counts and  
locking is an accident waiting to happen.

>
> RPM_Transaction.xs:323: error: too many arguments to function  
> 'rpmdbRemove'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_readheader':
> RPM_Transaction.xs:511: warning: implicit declaration of function  
> '_rpm2header'
> make[2]: *** [RPM_Transaction.o] Error 1
> cc -c  -I../. -I../build -I../lib -I../popt -I../rpmdb -I../rpmio
> -I../rpmconstant  -DRPM_OS_DARWIN=081001 -I/usr/local/src/bzip2-1.0.4
> -I/usr/local/src/beecrypt-4.1.2 -I/usr/local/src/neon-0.27.2/src
> -I/usr/local/src/popt-1.12 -I/usr/local/src/sqlite-3.5.0 -Wall
> -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes
> -Wno-char-subscripts -O0 -g3 -D_GNU_SOURCE -D_REENTRANT -g
> -DVERSION=\"5.0.DEVEL\" -DXS_VERSION=\"5.0.DEVEL\"
> "-I/System/Library/Perl/5.8.6/darwin-thread-multi-2level/CORE"
> RPM_Transaction.c
> RPM_Transaction.xs:135: warning: no previous prototype for  
> 'transCallback'
> RPM_Transaction.c: In function 'XS_RPM__Transaction_new':
> RPM_Transaction.c:246: warning: unused variable 'class'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_vsflags':
> RPM_Transaction.xs:262: warning: implicit declaration of function  
> 'sv2constant'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_packageiterator':
> RPM_Transaction.xs:297: warning: implicit declaration of function  
> '_newiterator'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_dbadd':
> RPM_Transaction.xs:308: error: too many arguments to function  
> 'rpmdbAdd'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_dbremove':
> RPM_Transaction.xs:323: error: too many arguments to function  
> 'rpmdbRemove'
> RPM_Transaction.xs: In function 'XS_RPM__Transaction_readheader':
> RPM_Transaction.xs:511: warning: implicit declaration of function  
> '_rpm2header'
> make[2]: *** [RPM_Transaction.o] Error 1
> make[1]: *** [.made_mod] Error 2
> make: *** [install-recursive] Error 1
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> Developer Communication List                        rpm-devel@rpm5.org