RPM Community Forums

Mailing List Message of <rpm-devel>

Re: small bug fix for "suggests"

From: Jeff Johnson <n3npq@mac.com>
Date: Tue 13 Nov 2007 - 14:30:54 CET
Message-Id: <F4FDCDA6-D462-48B6-ACC9-24AD48E2540A@mac.com>
Yes, thanks for the patch.

The other way to fix would be to save Flags in the response
cache so that the dependency remains a hint, rather than becoming
persistently "unsatisfiled", seen in the cache by other non-hinted
dependencies.

73 de Jeff

On Nov 13, 2007, at 5:23 AM, Pixel wrote:

> # if "a" suggests "b", rpm rightfully allows to remove "b"
> # but rpm must not put in cache that "b" can be removed,
> # because if "c" requires "b", rpm must not allow to remove "b"
> # (http://qa.mandriva.com/show_bug.cgi?id=34342)
>
> --- rpm-4.4.8/lib/depends.c.pix	2007-09-27 10:41:50.000000000 +0200
> +++ rpm-4.4.8/lib/depends.c	2007-10-02 11:07:36.000000000 +0200
> @@ -811,6 +811,7 @@ retry:
>  unsatisfied:
>      if (Flags & RPMSENSE_MISSINGOK) {
>  	rc = 0;	/* dependency is unsatisfied, but just a hint. */
> +	_cacheThisRC = 0;
>  	rpmdsNotify(dep, _("(hint skipped)"), rc);
>      } else {
>  	rc = 1;	/* dependency is unsatisfied */
Received on Tue Nov 13 14:31:19 2007
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.