On Dec 20, 2007, at 2:27 PM, Pixel wrote:

> fix truncated "file conflict" error message in russian
> (http://qa.mandriva.com/show_bug.cgi?id=31680)
> nb: the utf8 russian string is 124 chars, whereas the i18n'ed  
> should be <100bytes
>
> the patch uses asprintf. I'm not sure what compatibility is needed.
>
> a simpler patch not using asprintf is to raise the constant 100 to 200
> (or 300, who knows...)
>

Actually using formats from a table, and strlen on the actual
format to be used, would allow a precise estimate of the minimum
buffer size needed to not truncate.

> fix truncated "file conflict" error message in russian
> (http://qa.mandriva.com/show_bug.cgi?id=31680)
> nb: the utf8 russian string is 124 chars, whereas the i18n'ed  
> should be <100bytes
>

Nothing wrong that I can see with using asprintf though. There are
almost certainly portability issues somewhere however, rpm already
carries retrofits for snprintf and vsnprintf, asprintf and vasprintf
likely have additional portability problems.


Thanks for the patch.

73 de Jeff