RPM Community Forums

Mailing List Message of <rpm-devel>

Re: Size limit on tag values?

From: Jeff Johnson <n3npq@mac.com>
Date: Thu 27 Dec 2007 - 14:46:44 CET
Message-Id: <9492B796-A25D-43FC-BAE3-403D0D46D820@mac.com>

On Dec 27, 2007, at 2:37 AM, Ralf S. Engelschall wrote:

>>
>> So do you wish to raise the size of the parse buffer to, say, 200K?
>> Anything else is going to hard to fit into rpm-5.0 ...
>
> The problem is that a few hundret KB might be still too small. I think
> to really be able to put larger amounts into a tag we really would  
> have
> to implement the dynamic buffer reallocation. Any type of static  
> buffer
> just slightly moves forward the time when it starts breaking...
>
> Nevertheless we should increase from the rather small 10KB to  
> perhaps at
> least something like 100KB. This way it obviously is still unusable  
> for
> something like my "Environment" approach (where the data exponentially
> explodes even under tree pruning), but at least other tag hacks then
> work...

So add a macro to size the buffer and use malloc instead.

Personally, I'd just add the quick hack, choose a value that gets your
OpenPKG job done for now. The difference between 100K and 300K is hardly
worth the effort of discussing, both are still a quick hack.

73 de Jeff
Received on Thu Dec 27 14:46:52 2007
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.