RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm-5_0: rpm/ CHANGES macros.in

From: Jeff Johnson <n3npq@mac.com>
Date: Mon 04 Feb 2008 - 20:36:30 CET
Message-Id: <A50B0E03-1972-4984-A87F-D7FF178FD9EE@mac.com>

On Feb 4, 2008, at 1:59 PM, Ralf S. Engelschall wrote:

> On Mon, Feb 04, 2008, Jeff Johnson wrote:
>
>>   Modified files:           (Branch: rpm-5_0)
>>     rpm                     CHANGES macros.in
>> [...]
>>   -%patch(b:p:P:REz:F:d:) \
>>   +%patch(b:p:P:REz:F:d:) %{shrink:\
>> [...]
>
> Be careful. This I think is now broken as %{shrink:..} and
> other new features were not merged onto rpm-5_0.
>

Thanks for noticing. I'll check-in the macro.c builtin changes  
momentarily ...

> Ok, shrink might be harmless to merge, but in general I think we  
> should
> not merge new features back into rpm-5_0...
>

For "no-brainers" like %{realpath:...} and %{getenv:...} and % 
{shrink:...}
I think we're better off being aggressive in order to have common  
functionality.

All else depends on what is signified by "new" and "feature" or  
implied by "bug".

The rationale for pushing back "#%patch" should be obvious however.  
Stoopid issue ...

73 de Jeff
Received on Mon Feb 4 20:36:45 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.