RPM Community Forums

Mailing List Message of <rpm-devel>

Testing for POPT earlier in configure.ac?

From: Jeff Johnson <n3npq@mac.com>
Date: Tue 05 Feb 2008 - 03:54:01 CET
Message-Id: <1B29BC75-2EB0-4ACC-8AE6-DD90E23C105C@mac.com>
There's a failure mode where the compilation test for
popt fails because popt is mandatory, yet the test failed
because of an incompletely specified neon -> gnutls linkage.

Does it make sense to test for mandatory (and mostly
standalone) libraries like libpopt earlier in configure.ac?

Here's what I would do (but I'll leave the AutoFu to Ralf) below.

There are perhaps a few other reorganizations, like keyutils, that
perhaps should be done earlier as well.

73 de Jeff

Index: configure.ac
===================================================================
RCS file: /v/rpm/cvs/rpm/configure.ac,v
retrieving revision 2.281
diff -u -b -B -w -p -r2.281 configure.ac
--- configure.ac        29 Jan 2008 14:43:52 -0000      2.281
+++ configure.ac        5 Feb 2008 02:46:42 -0000
@@ -909,6 +909,13 @@ dnl ##

  AC_MSG_HEADER([THIRD-PARTY LIBRARIES (2/2)])

+dnl # POPT
+RPM_CHECK_LIB(
+    [POPT], [popt],
+    [popt], [poptGetContext], [popt.h],
+    [yes,external], [],
+    [], [AC_MSG_ERROR([mandatory POPT library not found])])
+
  dnl # ZLib
  RPM_CHECK_LIB(
      [ZLib], [zlib],
@@ -972,13 +979,6 @@ RPM_CHECK_LIB(
        fi
      ], [])

-dnl # POPT
-RPM_CHECK_LIB(
-    [POPT], [popt],
-    [popt], [poptGetContext], [popt.h],
-    [yes,external], [],
-    [], [AC_MSG_ERROR([mandatory POPT library not found])])
-
  dnl # Berkeley-DB & SQLite
  DBLIBSRCS=""
  RPM_CHECK_LIB(
Received on Tue Feb 5 03:54:17 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.