RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm/ CHANGES rpm/rpmio/ Makefile.am testit.sh tfts.c

From: Jeff Johnson <n3npq@mac.com>
Date: Sat 09 Feb 2008 - 14:01:28 CET
Message-Id: <85C1DD00-AEF0-4F7D-9E8C-860DED05A00E@mac.com>

On Feb 9, 2008, at 4:03 AM, Ralf S. Engelschall wrote:

> On Fri, Feb 08, 2008, Jeff Johnson wrote:
>
>> [...]
>>   +    - jbj: tie tget/tdir/tglob/tfts to a rpmio "make check".  
>> much more to do ...
>> [...]
>>    LINT = splint
>>
>>   -EXTRA_DIST = gengpg.sh tdir.c tfts.c tget.c thkp.c tput.c  
>> tglob.c tinv.c tkey.c trpmio.c lookup3.c tpw.c librpmio.vers
>>   +EXTRA_DIST = gengpg.sh thkp.c tput.c tinv.c tkey.c trpmio.c  
>> lookup3.c tpw.c librpmio.vers
>>
>>   -EXTRA_PROGRAMS = tdir tfts tget tglob thkp tinv tkey tmacro  
>> tmagic tmire tput tpw trpmio tsw dumpasn1 lookup3
>>   +EXTRA_PROGRAMS = thkp tinv tkey tmacro tmagic tmire tput tpw  
>> trpmio tsw dumpasn1 lookup3
>>   +
>>   +noinst_PROGRAMS = tdir tfts tget tglob
>>   +noinst_SCRIPTS = testit.sh
>>   +
>>   +TESTS = testit.sh
>
> Sorry, Jeff, this cannot be done. It worked for you only because you
> still have not built from scratch. Else you would have noticed that  
> this
> requires build/ and lib/ to be built _BEFORE_ rpmio/ stuff and this
> breaks the library dependency hierarchy!
>
> It is important that the test programs in rpmio/ which need build/ and
> lib/ are marked as EXTRA_ stuff so they are *not* built automatically
> during the the regular build. By moving them to noinst_XXXX they are
> attempted to be build and this breaks the regular build procedure now.
> I had to back this change out in order to unbreak the regular  
> building.
>
> If you really wish those test programs to be build automatically I
> recommend to move all of them into a separate directory (e.g. tools/)
> and additionally perhaps allow one to disable their building via
> --without-tests, too.
>                                        Ralf S. Engelschall
>                                        rse@engelschall.com
>                                        www.engelschall.com
>
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> Developer Communication List                        rpm-devel@rpm5.org
Received on Sat Feb 9 14:01:49 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.