RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [Fwd: [Rpm-maint] [patch] warnings for rpmExpand(), rpmlog(), rpmGetPath()]

From: Jeff Johnson <n3npq@mac.com>
Date: Wed 13 Feb 2008 - 17:16:35 CET
Message-Id: <4A5AD908-68C7-4871-906B-AB9F47275C3F@mac.com>

On Feb 13, 2008, at 11:05 AM, Mark Hatle wrote:

> This is a fairly interesting patch that was sent to the rpm.org  
> list. Is this something we're interested in?  It may point out some  
> issues with rpm5, or future development.. (At the expense of gcc 4...)
>

I'll look at folding in today.

I'd rather see something other than

#ifdef GNU && GFOO

adverts on every prototype however. elfutils does a better job hiding  
the goop.

And I tend to try to avoid fancy formatting by casting, rather than  
priting
complete values. That also is less debugging spew to examine and
one hardly every needs all the bleeping bits.

 From memory, recOffset in lib/query.c is always 32 bits, dunno why %d
is not sufficient (should likely be%u <shrug>)

73 de Jeff
Received on Wed Feb 13 17:16:53 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.