On Feb 21, 2008, at 3:44 PM, Per Øyvind Karlsen wrote:

> Here's an improved and more upstream friendly version of syslog  
> patch from
> Mandriva which adds logging of install/remove of packages to syslog.
>
> It will be disabled by default, but can be activated by  
> %_log_to_syslog macro.
>
> Any objections of commiting or ideas of improvement?

Yes.

What needs doing is to add a "append-only" mode to log to file,
and a "use-syslog" flag to accomodate those that wish,
that delivers the results of a headerSprintf() queryformat to a log
file.

Follow the (esentially) logging that already exists to populate /var/ 
cache/hrmib
for use by the net-snmp HR-MIB in rpmdbAdd/rpmdbRemove to see
where the configurable logging needs to be done.

And imho, logging +foo/-bar is largely pointless for anything other than
filling up a disk with rubbish. There's too little useful information  
with
NVRA to be useful for debugging, and rpm already has a more powerful
database with a query mechanism for storing the useful information, and
a more powerful verification mechanism to verify that the data is  
indeed,
reliable.

  A historical, erase-only log might be useful, but that's not what  
your patch
is aiming to do.

73 de Jeff