On Fri, Mar 07, 2008, Jeff Johnson wrote:

> On Mar 7, 2008, at 9:37 AM, Ralf S. Engelschall wrote:
>> On Fri, Mar 07, 2008, Jeff Johnson wrote:
>>> On Mar 7, 2008, at 5:52 AM, Ralf S. Engelschall wrote:
>>>> On Fri, Mar 07, 2008, Ralf S. Engelschall wrote:
>>>>
>>>>> HEAD is of today is broken:
>>>>>
>>>>> ../rpmio/.libs/librpmio.a(iosm.o): In function `iosmMapAttrs':
>>>>> /u/rse/prj/rpm/src/rpm/rpmio/iosm.c:948: undefined reference to
>>>>> `headerIsEntry'
>>>>> /u/rse/prj/rpm/src/rpm/rpmio/iosm.c:962: undefined reference to
>>>>> `headerIsEntry'
>>>>> collect2: ld returned 1 exit status
>>>>
>>>> Ah, I see: this occured only for me because the headerIsEntry() call is
>>>> under RPM_VENDOR_OPENPKG. Ok, but what is the solution here?
>>>>
>>>
>>> The solution is easy: disable headerIsEntry() in iosm.c. I'll have a
>>> checkin in a moment.
>>
>> Sorry, I do not understand your checkin, Jeff. You changed the define
>> and this way the code is disabled. Ok. Sure, this fixes the building,
>> of course. But what about the intended functionality? How can I still
>> ensure that RPM does not try to set file owner/group on files during
>> installation of _source_ RPMs (and only for _source_ RPMs). I really
>> still need this functionality in OpenPKG. So, how can now again be
>> achieved?
>
> The actual functionality that you desire is exactly where you added in
> lib/fsm.c:854 fsmMapAttrs(). Works exactly as it has always worked.
>
> Meanwhile, I'm refactoring code, so there is duplication, but the
> replacement iosmMapAttrs() is not called on any rpm code path yet.

Ah, I see. The actual code is in fsm.c and the broken stuff in iosm.c
came through the recent refactorings only. Ok, now understood. Thanks
for clarification and fixing.

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com