RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm/ VENDOR rpm/rpmio/ macro.c

From: Ralf S. Engelschall <rse+rpm-devel@rpm5.org>
Date: Sun 13 Apr 2008 - 14:23:20 CEST
Message-ID: <20080413122320.GA70107@engelschall.com>
On Sun, Apr 13, 2008, Anders F Björklund wrote:

> Ralf S. Engelschall wrote:
>
>>   RPM Package Manager, CVS Repository
>>   +    else if (   (file_len > 3 && strcasecmp(file+file_len-3, ".lz") ==
>> 0)
>>   +             || (file_len > 3 && strcasecmp(file+file_len-3, ".7z") ==
>> 0)
>>   +             || (file_len > 5 && strcasecmp(file+file_len-5, ".lzma")
>> == 0)) {
>>   +        *compressed = COMPRESSED_LZMA;
>>   +        return 0;
>>   +    }
>
> This is not correct, 7-zip is a different format from LZMA (compare
> zip/gzip)
> Might want to add a COMPRESSED_7ZIP some day, to handle the p7zip*
> archives...
>
> * see http://sourceforge.net/projects/p7zip/
>
> But it should probably be:
>
>     else if (   (file_len > 4 && strcasecmp(file+file_len-3, ".tlz") == 0)
>              || (file_len > 5 && strcasecmp(file+file_len-5, ".lzma") ==
> 0)) {

Ok, now adjusted. Thanks for the hint.

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com
Received on Sun Apr 13 14:26:21 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.