On Apr 18, 2008, at 5:15 PM, Jeff Johnson wrote:
>
> On Apr 18, 2008, at 5:00 PM, Göran Uddeborg wrote:
>
>>
>> Wouldn't it be ok to write
>>
>> fprintf(stderr, _("command-line %d"), count)
>>
>> instead?
>
> Most definitely. The ord() routine was carried forward
> from pcregrep, which is wonderful code, but had no attempt at i18n.
>
> I'll fix in a moment.
>
Here's the real reason I dinna fix before: I was interested in using
the automated testing while developing a mire API w PCRE patterns.
While hacking code, it was useful to be _IDENTICAL_ to the pcregrep
test.
But its trivial to adjust the tests now that the heavy hacking has
been accomplished.
--- ./testdata/grepoutput 2008-02-11 16:47:00.000000000 -0500
+++ testtry 2008-04-18 17:19:13.000000000 -0400
@@ -84,7 +84,7 @@
---------------------------- Test 14 -----------------------------
./testdata/grepinputx:To pat or not to pat, that is the question.
---------------------------- Test 15 -----------------------------
-pcregrep: Error in command-line regex at offset 4: nothing to repeat
+pcregrep: Error incommand-line 0 regex at offset 4: nothing to repeat
---------------------------- Test 16 -----------------------------
pcregrep: Failed to open ./testdata/nonexistfile: No such file or
directory
---------------------------- Test 17 -----------------------------
@@ -373,7 +373,7 @@
596:binary
597:binary
---------------------------- Test 45 ------------------------------
-pcregrep: Error in 2nd command-line regex at offset 9: missing )
+pcregrep: Error incommand-line 2 regex at offset 9: missing )
---------------------------- Test 46 ------------------------------
AB.VE
---------------------------- Test 47 ------------------------------
73 de Jeff
Received on Fri Apr 18 23:23:04 2008