RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm/rpmio/ poptIO.c

From: Jeff Johnson <n3npq@mac.com>
Date: Sat 24 May 2008 - 19:02:00 CEST
Message-id: <20933F69-4662-42B7-91D9-368BF68CD197@mac.com>
The reason for macro expanding was preliminaries for persistent
configgery of crypto implementation, just never finished.

Likely rpmExpand() is/was the wrong approach too, rethinking
what I was attemptint at the time ...

73 de Jeff

On May 24, 2008, at 12:58 PM, Ralf S. Engelschall wrote:

>   RPM Package Manager, CVS Repository
>   http://rpm5.org/cvs/
>    
> ______________________________________________________________________ 
> ______
>
>   Server: rpm5.org                         Name:   Ralf S. Engelschall
>   Root:   /v/rpm/cvs                       Email:  rse@rpm5.org
>   Module: rpm                              Date:   24-May-2008  
> 18:58:28
>   Branch: HEAD                             Handle: 2008052416582800
>
>   Modified files:
>     rpm/rpmio               poptIO.c
>
>   Log:
>     I see no reason why one wishes to macro expand the --usecrypto
>     argument, but even if there is a reason there is already the code
>     under NOTYET, so no need to do it twice
>
>   Summary:
>     Revision    Changes     Path
>     1.26        +1  -1      rpm/rpmio/poptIO.c
>    
> ______________________________________________________________________ 
> ______
>
>   patch -p0 <<'@@ .'
>   Index: rpm/rpmio/poptIO.c
>    
> ====================================================================== 
> ======
>   $ cvs diff -u -r1.25 -r1.26 poptIO.c
>   --- rpm/rpmio/poptIO.c	24 May 2008 16:44:51 -0000	1.25
>   +++ rpm/rpmio/poptIO.c	24 May 2008 16:58:28 -0000	1.26
>   @@ -234,7 +234,7 @@
>    	break;
>    #endif	/* NOTYET */
>        case POPT_CRYPTO:
>   -	{   const char *val = rpmExpand(arg, NULL);
>   +	{   const char *val;
>    #ifdef	NOTYET
>    	    rpmioConfigured();
>    	    val = rpmExpand(arg, NULL);
>   @@ .
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> CVS Sources Repository                                rpm-cvs@rpm5.org
Received on Sat May 24 19:04:19 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.