RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm-5_1: rpm/rpmio/ argv.h

From: Ralf S. Engelschall <rse+rpm-devel@rpm5.org>
Date: Tue 29 Jul 2008 - 18:35:55 CEST
Message-ID: <20080729163555.GA9588@engelschall.com>
On Tue, Jul 29, 2008, Arkadiusz Miskiewicz wrote:

> [...]
>     Include stdint.h for uintXX_t types.
>
>   Summary:
>     Revision    Changes     Path
>     1.8.2.2     +2  -0      rpm/rpmio/argv.h
>   ____________________________________________________________________________
>
>   patch -p0 <<'@@ .'
>   Index: rpm/rpmio/argv.h
>   ============================================================================
>   $ cvs diff -u -r1.8.2.1 -r1.8.2.2 argv.h
>   --- rpm/rpmio/argv.h	31 May 2008 16:59:03 -0000	1.8.2.1
>   +++ rpm/rpmio/argv.h	29 Jul 2008 15:01:57 -0000	1.8.2.2
>   @@ -5,6 +5,8 @@
>     * \file rpmio/argv.h
>     */
>
>   +#include <stdint.h>
>   +
>    typedef	const char * ARGstr_t;
>    typedef ARGstr_t * ARGV_t;
> [...]

Even if we are already in 2008, unconditionally including the C99
header <stdint.h> is not recommended as it breaks platform portability.
We really have to wrap this. If you want to externally include this
"argv.h" outside the RPM source tree one really has to supply #defines
to enable those includes.
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com
Received on Tue Jul 29 18:40:07 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.