RPM Community Forums

Mailing List Message of <rpm-devel>

Re: RPM: rpm/ CHANGES rpm/rpmio/ gzdio.c

From: Alexey Tourbin <at@altlinux.ru>
Date: Wed 06 Aug 2008 - 18:30:50 CEST
Message-ID: <20080806163050.GG20176@solemn.turbinal>
On Wed, Aug 06, 2008 at 05:09:30AM -0400, Jeff Johnson wrote:
> So that's what I screwed. Tired old blind eyes here, sigh.

void pointers are evil.  gzFile is typdeffed as "void *",
which means there's no chances left for compiler to complain
about pointer type mismatch.  They'd better typdef gzFile
as "struct gzFile_s *" or something.

> Thanks for the fix! Next tasks are to unwire internal zlib, and hint
> the need for compressor flushing slightly differently (from iosm.c) ...

BTW, it is not possible to make lzma rsyncable, at least for now.
In lzma_alone format, there's no block partitioning at all.
It's just a huge single block, as far as I see.

There are other reasons why lzma compressed data cannot be effectively
rsyncable.  Certain conditions must be met, including small dictionary size
(gzip has 32K dictionary size, and lzma works best with ~2M dictionary
size).  Basically it's either ultimate compression with lzma or
rsyncability with good old gzip.

  • application/pgp-signature attachment: stored
Received on Wed Aug 6 18:30:55 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.