2008/10/4 Ralf S. Engelschall <rse+rpm-devel@rpm5.org<rse%2Brpm-devel@rpm5.org>
>
> On Sat, Oct 04, 2008, Per Øyvind Karlsen wrote:
>
> > [...]
> > + lzma_stream tmp =
> > +#if LZMA_VERSION == 49990030
> > + LZMA_STREAM_INIT_VAR;
> > +#else
> > + LZMA_STREAM_INIT;
> > +#endif
>
> What happens on the next versions?
> Wouldn't be a LZMA_VERSION >= 49990030 better here?
nope, 49990030 is old, and the specific code part will only work with this
version, the other code
is for the new and hopefully stabilized api from 49990060 and on.
(There's been some various api breakages between these versions that I don't
care to bother
about at all..)
One could of course argue that it could be turned around and >= 49990060 or
something would be
better, but it's not really that relevant, the conditional should die
eventually, I only left compatibility with
49990030 there for now since this is the version that most people probably
use currently.
Still, support for this old version should really die soon..
Received on Tue Oct 7 16:10:24 2008