RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [PATCH] Compile popt under Windows using gnulib

From: Richard W.M. Jones <rjones@redhat.com>
Date: Sat 25 Oct 2008 - 17:42:06 CEST
Message-ID: <20081025154206.GG3678@amd.home.annexia.org>
On Sat, Oct 25, 2008 at 11:31:49AM -0400, Jeff Johnson wrote:
> FYI: patches to <popt-devel@rpm5.org>, please. I'll take
> patches however they are sent however. *shrug*
>
> I can't tie builds of popt to gnulib, even for cross-compiles, there's  
> way too many
> projects that depend on popt.

Gnulib is a source code library, not a "library" library, so in normal
usage Gnulib source files are included in the final tarball:

http://www.gnu.org/software/gnulib/manual/gnulib.html#Library-vs-Reusable-Code

So there's no extra dependency.

As for whether you store the Gnulib files inside your version control
system, that is a slightly different issue, discussed here:

http://www.gnu.org/software/gnulib/manual/gnulib.html#VCS-Issues

> What could be done is disable the usage of glob(3)
> if glob is not available through configure tests.

While I agree this is one way to do it, it does mean that Windows
users get one less feature.  AIUI globbing is used to implement the
/etc/popt.d/* directory (?), hard-coded in the source unfortunately.

There's actually another portability issue which Gnulib can help with
in the future - namely, random/srandom missing.  I hacked around this
in the patch I just sent, but Gnulib will solve it properly (and also
for other platforms, not just Windows, which lack these calls).  I've
got a patch for Gnulib lined up to provide the random family of
functions.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top
Received on Sat Oct 25 17:42:28 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.