RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: lua/ Makefile.am rpm/ CHANGES

From: Jeff Johnson <n3npq@mac.com>
Date: Sun 02 Nov 2008 - 14:46:17 CET
Message-id: <456CA618-7F64-4574-918D-84D214B251B1@mac.com>

On Nov 2, 2008, at 3:26 AM, Ralf S. Engelschall wrote:

> On Sun, Nov 02, 2008, Per Øyvind Karlsen wrote:
>
>> [...]
>>    lua: explicitly link against libexpat as assumption on implicit  
>> linking cannot
>>    be guaranteed.
>> [...]
>>  -liblua_la_LIBADD = @WITH_LUA_SUBDIR_LIB@ -lm
>>  +liblua_la_LIBADD = @WITH_LUA_SUBDIR_LIB@ -lm -lexpat
>>   liblua_la_SOURCES += \
>>   	local/llocal.c \
>>   	local/llocal.h \
>
> Errr... no, please don't to that. Lua does not unconditionally  
> depend on
> Expat AFAIK, at least I build RPM+Lua on all platforms without any  
> expat
> there. So, at least no hard-coded dependencies to third-party  
> libraries.
> The -lm is fine as it is a system library which always exists. But a
> hard-coded -lexpat is not acceptable IMHO.
>

HEAD has lua/lxplib.c atm, so -lexpat is needed if neon doesn't bring
accidentally bring in the library.

I have no intention leaving lxplib.c needing -lexpat as is. Supporting
external lua DLL's is likely least intrusive to RPM code, and looks
feasible if some conventional moducle search paths are established for
lua internal to rpm.

Note that lcrypto.c has an implicit need for -lopenssl atm roo, needed
for digests to opendht.org.

73 de Jeff
Received on Sun Nov 2 14:46:20 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.