RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm/ CHANGES rpm/rpmio/ Makefile.am

From: Jeff Johnson <n3npq@mac.com>
Date: Fri 05 Dec 2008 - 05:22:56 CET
Message-id: <2CA3BD34-A1D4-4724-8E26-9C2EA807DA04@mac.com>
What needed "fixing"?

I have built using internal lua daily without these changes.

Can you try to pin down what changed so that this patch is now needed  
please?

Likely trying to build rpm-5.1.6, without these changes, would
be the easiest way to identify if there is a regression.

73 de Jeff


On Dec 4, 2008, at 8:13 PM, Per Řyvind Karlsen wrote:

>  RPM Package Manager, CVS Repository
>  http://rpm5.org/cvs/
>   
> ____________________________________________________________________________
>
>  Server: rpm5.org                         Name:   Per Řyvind Karlsen
>  Root:   /v/rpm/cvs                       Email:  pkarlsen@rpm5.org
>  Module: rpm                              Date:   05-Dec-2008 02:13:42
>  Branch: HEAD                             Handle: 2008120501134200
>
>  Modified files:
>    rpm                     CHANGES
>    rpm/rpmio               Makefile.am
>
>  Log:
>    fix linking against internal lua. (hm, might be more appropriate
>    places to add?)
>
>  Summary:
>    Revision    Changes     Path
>    1.2664      +1  -0      rpm/CHANGES
>    1.196       +7  -3      rpm/rpmio/Makefile.am
>   
> ____________________________________________________________________________
>
>  patch -p0 <<'@@ .'
>  Index: rpm/CHANGES
>   
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
>  $ cvs diff -u -r1.2663 -r1.2664 CHANGES
>  --- rpm/CHANGES	3 Dec 2008 21:11:02 -0000	1.2663
>  +++ rpm/CHANGES	5 Dec 2008 01:13:42 -0000	1.2664
>  @@ -1,5 +1,6 @@
>
>   5.2a2 -> 5.2a3:
>  +    - proyvind: fix linking against internal lua.
>       - jbj: perl: add a sentinel to rpmdsSingle() rather than  
> exporting rpmdsDup().
>       - jbj: fix: better choice for paths to add (#473814 comment #4).
>       - proyvind: perl: add api doc for RPM::Spec->icon() &  
> RPM::Spec->icon_url().
>  @@ .
>  patch -p0 <<'@@ .'
>  Index: rpm/rpmio/Makefile.am
>   
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
>  $ cvs diff -u -r1.195 -r1.196 Makefile.am
>  --- rpm/rpmio/Makefile.am	14 Oct 2008 19:24:10 -0000	1.195
>  +++ rpm/rpmio/Makefile.am	5 Dec 2008 01:13:42 -0000	1.196
>  @@ -47,7 +47,9 @@
>   RPMIO_LDADD_COMMON = \
>   	librpmio.la \
>   	$(top_builddir)/misc/librpmmisc.la \
>  -	@LTLIBINTL@
>  +	@LTLIBINTL@ \
>  +	@WITH_LUA_LDFLAGS@ \
>  +	@WITH_LUA_LIBS@
>
>   RPM_LDADD_COMMON = \
>   	$(top_builddir)/build/librpmbuild.la \
>  @@ -80,11 +82,13 @@
>   	rpmkeyring.c rpmku.c rpmlog.c rpmlua.c rpmmalloc.c rpmmg.c  
> rpmnss.c rpmpgp.c \
>   	rpmrpc.c rpmsq.c rpmssl.c rpmsw.c rpmuuid.c rpmxar.c \
>   	strcasecmp.c strtolocale.c tar.c url.c ugid.c
>  -librpmio_la_LDFLAGS = -release $(LT_CURRENT).$(LT_REVISION)
>  +librpmio_la_LDFLAGS = -release $(LT_CURRENT).$(LT_REVISION) \
>  +	@WITH_LUA_LDFLAGS@
>   if HAVE_LD_VERSION_SCRIPT
>   librpmio_la_LDFLAGS += -Wl,--version-script=$(srcdir)/librpmio.vers
>   endif
>  -librpmio_la_LIBADD =
>  +librpmio_la_LIBADD = \
>  +	@WITH_LUA_LIBS@
>   if ENABLE_BUILD_INTLIBDEP
>   librpmio_la_LIBADD += \
>   	$(top_builddir)/misc/librpmmisc.la
>  @@ .
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> CVS Sources Repository                                rpm-cvs@rpm5.org



  • application/pkcs7-signature attachment: smime.p7s
Received on Fri Dec 5 05:23:17 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.