RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm/lib/ filetriggers.c

From: Jeff Johnson <n3npq@mac.com>
Date: Tue 23 Dec 2008 - 22:57:39 CET
Message-id: <B6611215-4EEF-44AA-9DEA-69425D3DC200@mac.com>
This patch isn't needed.

system.h will include "config.h" if -DHAVE_CONFIG_H is defined
in CFLAGS, which is done throughout rpm.

And RPM_VENDOR_FOO is passed through CFLAGS, not config.h,
simpilarly to -DHAVE_CONFIG_H.

See your change to the AutoFu for one example ;-)

73 de Jeff

On Dec 22, 2008, at 10:54 AM, Per Řyvind Karlsen wrote:

>   RPM Package Manager, CVS Repository
>   http://rpm5.org/cvs/
>    
> ______________________________________________________________________ 
> ______
>
>   Server: rpm5.org                         Name:   Per Řyvind Karlsen
>   Root:   /v/rpm/cvs                       Email:  pkarlsen@rpm5.org
>   Module: rpm                              Date:   22-Dec-2008  
> 16:54:06
>   Branch: HEAD                             Handle: 2008122215540600
>
>   Modified files:
>     rpm/lib                 filetriggers.c
>
>   Log:
>     include config.h on top of file since RPM_VENDOR_MANDRIVA is  
> defined there
>     rather than by passing CPPFLAGS variable
>
>   Summary:
>     Revision    Changes     Path
>     2.14        +2  -0      rpm/lib/filetriggers.c
>    
> ______________________________________________________________________ 
> ______
>
>   patch -p0 <<'@@ .'
>   Index: rpm/lib/filetriggers.c
>    
> ====================================================================== 
> ======
>   $ cvs diff -u -r2.13 -r2.14 filetriggers.c
>   --- rpm/lib/filetriggers.c	20 Dec 2008 23:14:51 -0000	2.13
>   +++ rpm/lib/filetriggers.c	22 Dec 2008 15:54:06 -0000	2.14
>   @@ -1,3 +1,5 @@
>   +#include "config.h"
>   +
>    #if defined(RPM_VENDOR_MANDRIVA)
>    #include "system.h"
>
>   @@ .
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> CVS Sources Repository                                rpm-cvs@rpm5.org
Received on Tue Dec 23 22:57:47 2008
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.