RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm/ CHANGES rpm/js/ rpmte-js.c rpm/lib/ rpmgi.c

From: Jeff Johnson <n3npq@mac.com>
Date: Fri 27 Nov 2009 - 20:10:32 CET
Message-id: <9A84125A-453E-4D6C-8080-617FF2BD5A18@mac.com>

On Nov 27, 2009, at 11:24 AM, devzero2000 wrote:
>>>
>>>    complete changing db2offset data type to uint32_t everywhere
>> Should've rather been rpmuint32_t, no?
> Yes, but uint32_t is used in many place now and i have no clue why :
> Just a typo perhaps?. Is is right to change everywhere ? BTW, no
> problem in doing this.

It's a bit confusing.

The rpmuint32_t et al typedefs should be using for integers derived from
Header metadata.

At one point, rpmuint32_t was also used to avoid newer C types like  
uint32_t
for portability but that battle was lost more than a year ago.

Meanwhile, the rpmdb schema change now has a uint32_t primary index on
Packages. IIRC "unsigned int" was used before.

hth

73 de Jeff



  • application/pkcs7-signature attachment: smime.p7s
Received on Fri Nov 27 20:10:58 2009
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.