RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm/rpmdb/ db3.c

From: Jeff Johnson <n3npq@mac.com>
Date: Tue 18 Jan 2011 - 00:38:06 CET
Message-id: <605421F2-7F87-4A20-8906-D104E97CA220@mac.com>
Rip it out please. Or I will.

One cvan set the log directory in DB_CONFIG.

Using DB_CONFIG is the means to set parameteres configrurably
for Berkeley DB. If you find the Berekeley DB configuration
machainsim useless, go honk at Orackle, not hack in rpmdb/db3.c

Yes I'm serious. All of the overrides in rpmdb/db3.c are
going away.

73 de Jeff


On Jan 17, 2011, at 6:29 PM, Per Řyvind Karlsen wrote:

>  RPM Package Manager, CVS Repository
>  http://rpm5.org/cvs/
>  ____________________________________________________________________________
> 
>  Server: rpm5.org                         Name:   Per Řyvind Karlsen
>  Root:   /v/rpm/cvs                       Email:  pkarlsen@rpm5.org
>  Module: rpm                              Date:   18-Jan-2011 00:29:54
>  Branch: HEAD                             Handle: 2011011723295300
> 
>  Modified files:
>    rpm/rpmdb               db3.c
> 
>  Log:
>    always set log directory
> 
>  Summary:
>    Revision    Changes     Path
>    1.160       +9  -11     rpm/rpmdb/db3.c
>  ____________________________________________________________________________
> 
>  patch -p0 <<'@@ .'
>  Index: rpm/rpmdb/db3.c
>  ============================================================================
>  $ cvs diff -u -r1.159 -r1.160 db3.c
>  --- rpm/rpmdb/db3.c	13 Jan 2011 06:39:05 -0000	1.159
>  +++ rpm/rpmdb/db3.c	17 Jan 2011 23:29:53 -0000	1.160
>  @@ -920,20 +920,18 @@
>       }
> 
>   /* ==== Logging: */
>  -    if (eflags & DB_INIT_LOG) {
>  -	const char *logdir;
>  +    const char *logdir;
> 
>  -	logdir = rpmGetPath(dbhome, "/", "log", NULL);
>  -	/*
>  -	 * Create the /var/lib/rpm/log directory if it doesn't exist (root only).
>  -	 */
>  -	rpmioMkpath(logdir, 0755, getuid(), getgid());
>  +    logdir = rpmGetPath(dbhome, "/", "log", NULL);
>  +    /*
>  +     * Create the /var/lib/rpm/log directory if it doesn't exist (root only).
>  +     */
>  +    rpmioMkpath(logdir, 0755, getuid(), getgid());
> 
>  -	xx = dbenv->set_lg_dir(dbenv, logdir);
>  -	xx = cvtdberr(dbi, "dbenv->set_lg_dir", xx, _debug);
>  +    xx = dbenv->set_lg_dir(dbenv, logdir);
>  +    xx = cvtdberr(dbi, "dbenv->set_lg_dir", xx, _debug);
> 
>  -	_free(logdir);
>  -    }
>  +    _free(logdir);
> 
>   /* ==== Memory pool: */
>       if (eflags & DB_INIT_MPOOL) {
>  @@ .
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> CVS Sources Repository                                rpm-cvs@rpm5.org



  • application/pkcs7-signature attachment: smime.p7s
Received on Tue Jan 18 00:38:29 2011
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.