RPM Community Forums

Mailing List Message of <rpm-devel>

Re: disttag/distepoch in RPMTAG_NVRA [Fwd: [Cooker] Warning: remaining bugs in RPM ? (no distro tag)]

From: Jeff Johnson <n3npq@mac.com>
Date: Thu 20 Jan 2011 - 01:19:02 CET
Message-id: <56FF3EC9-C5D6-4A25-AE92-256F3D223E07@mac.com>

On Jan 19, 2011, at 7:01 PM, Jeff Johnson wrote:

> 
> On Jan 19, 2011, at 7:45 AM, Per Řyvind Karlsen wrote:
> 
>> For RPMTAG_NVRA to expand to using%{___NVRA}, I found myself
>> having to modify hGetNevra().
>> 
> 
> Why did you have to modify?
> 
> While this setting is a huge mess, its _IS_ adequate to compose
> an "identification" string based on other tag data:
> 
> %___NVRA        %%{NAME}-%%{VERSION}-%%{RELEASE}%%|DISTTAG?{-%%{DISTTAG}%%|DISTEPOCH?{%%{DISTEPOCH}}|}|%%|ARCH?{.%%|SOURCERPM?{%%{ARCH}}:{src}|}:{}|
> 
> I fail to understand why changes to hGetNevra() method are _ALSO_ needed.
> 

Hmmm ... hGetNVRA is crap that needs to ripped out.

The NVRA tag extension that calls hGetNVRA is crap as well.

Both were left exactly as is when %___NVRA (which is a general
--queryformat expression) was added.

I'll have to look more carefully next week (I'm still on the road),
but having headerGet() recurse through headerSprintf() to evaluate
%{___NVRA} strings is what may be needed to haul out the crap.

hth

73 de Jeff



  • application/pkcs7-signature attachment: smime.p7s
Received on Thu Jan 20 01:21:41 2011
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.