RPM Community Forums

Mailing List Message of <rpm-devel>

Re: [CVS] RPM: rpm-5_3: rpm/rpmdb/ db3.c

From: Jeff Johnson <n3npq@mac.com>
Date: Mon 24 Jan 2011 - 14:44:42 CET
Message-id: <AAE3C906-7BF6-4C73-99A6-4CCE8ADD3659@mac.com>
This is sureto be controversial ... can't be helped.

Configuring Berkeley DB occurs outside of RPM to the greatest extent possible.

I have no desire to revisit Berkeley DB conversions or compatibility
whatsoever in RPM code. If you want lay log dir creation, the patch
goes to Berekeley DB, not RPM.

If Mandriva wants to convert rpmdb's forwards/backwards/whatever, then
that will have to be done outside of rpm libraries.

Conventions like /var/lib/rpm/log _CANNOT_ be automated yet,
and _WILL_ change. If anything, /var/lib/rpm/filetriggers needs to move
somewhere else; the alternative is that I will move everything else in
an rpmdb in order to achieve a coherent security policy based on uid/gid
on a directory.

All of this has been said before, repeatedly.

73 de Jeff



On Jan 24, 2011, at 8:32 AM, Jeff Johnson wrote:

>  RPM Package Manager, CVS Repository
>  http://rpm5.org/cvs/
>  ____________________________________________________________________________
> 
>  Server: rpm5.org                         Name:   Jeff Johnson
>  Root:   /v/rpm/cvs                       Email:  jbj@rpm5.org
>  Module: rpm                              Date:   24-Jan-2011 14:32:28
>  Branch: rpm-5_3                          Handle: 2011012413322700
> 
>  Modified files:           (Branch: rpm-5_3)
>    rpm/rpmdb               db3.c
> 
>  Log:
>    - use DB_CONFIG to establish log directory location.
> 
>  Summary:
>    Revision    Changes     Path
>    1.150.2.8   +0  -12     rpm/rpmdb/db3.c
>  ____________________________________________________________________________
> 
>  patch -p0 <<'@@ .'
>  Index: rpm/rpmdb/db3.c
>  ============================================================================
>  $ cvs diff -u -r1.150.2.7 -r1.150.2.8 db3.c
>  --- rpm/rpmdb/db3.c	17 Jan 2011 23:31:41 -0000	1.150.2.7
>  +++ rpm/rpmdb/db3.c	24 Jan 2011 13:32:27 -0000	1.150.2.8
>  @@ -920,18 +920,6 @@
>       }
> 
>   /* ==== Logging: */
>  -    const char *logdir;
>  -
>  -    logdir = rpmGetPath(dbhome, "/", "log", NULL);
>  -    /*
>  -     * Create the /var/lib/rpm/log directory if it doesn't exist (root only).
>  -     */
>  -    rpmioMkpath(logdir, 0755, getuid(), getgid());
>  -
>  -    xx = dbenv->set_lg_dir(dbenv, logdir);
>  -    xx = cvtdberr(dbi, "dbenv->set_lg_dir", xx, _debug);
>  -
>  -    _free(logdir);
> 
>   /* ==== Memory pool: */
>       if (eflags & DB_INIT_MPOOL) {
>  @@ .
> ______________________________________________________________________
> RPM Package Manager                                    http://rpm5.org
> CVS Sources Repository                                rpm-cvs@rpm5.org
Received on Mon Jan 24 14:45:03 2011
Driven by Jeff Johnson and the RPM project team.
Hosted by OpenPKG and Ralf S. Engelschall.
Powered by FreeBSD and OpenPKG.